From 08ca2a2db380ab8717a451e3f750a489ffd8eb7d Mon Sep 17 00:00:00 2001 From: Steven Wallace <792372+cherez@users.noreply.github.com> Date: Mon, 5 May 2025 10:37:28 -0500 Subject: [PATCH] Fixed doubled first name in templates v12.3.0 caused a regression with contributors with a single word name, causing the name to be doubled. This was caused by using that name as both the first and last name, so swap the first name with the (blank) last name rather than duplicate them. --- Source/LibationFileManager/Templates/ContributorDto.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Source/LibationFileManager/Templates/ContributorDto.cs b/Source/LibationFileManager/Templates/ContributorDto.cs index e52d26d8..593c7950 100644 --- a/Source/LibationFileManager/Templates/ContributorDto.cs +++ b/Source/LibationFileManager/Templates/ContributorDto.cs @@ -24,10 +24,12 @@ public class ContributorDto : IFormattable //Single-word names parse as first names. Use it as last name. var lastName = string.IsNullOrWhiteSpace(HumanName.Last) ? HumanName.First : HumanName.Last; + //Because of the above, if the have only a first name, then we'd double the name as "FirstName FirstName", so clear the first name in that situation. + var firstName = string.IsNullOrWhiteSpace(HumanName.Last) ? HumanName.Last : HumanName.First; return format .Replace("{T}", HumanName.Title) - .Replace("{F}", HumanName.First) + .Replace("{F}", firstName) .Replace("{M}", HumanName.Middle) .Replace("{L}", lastName) .Replace("{S}", HumanName.Suffix)