- Increase account privacy in logs

- Improve book download retry
This commit is contained in:
Robert McRackan 2020-12-14 15:42:27 -05:00
parent f9849abb7b
commit 1812fc2c7c
5 changed files with 11 additions and 8 deletions

View File

@ -81,16 +81,13 @@ namespace ApplicationServices
{ {
ArgumentValidator.EnsureNotNull(account, nameof(account)); ArgumentValidator.EnsureNotNull(account, nameof(account));
var localeName = account.Locale?.Name;
Log.Logger.Information("ImportLibraryAsync. {@DebugInfo}", new Log.Logger.Information("ImportLibraryAsync. {@DebugInfo}", new
{ {
AccountName = account.AccountName.ToMask(), Account = account?.MaskedLogEntry ?? "[null]"
AccountId = account.AccountId.ToMask(),
LocaleName = localeName,
}); });
var dtoItems = await AudibleApiActions.GetLibraryValidatedAsync(api); var dtoItems = await AudibleApiActions.GetLibraryValidatedAsync(api);
return dtoItems.Select(d => new ImportItem { DtoItem = d, AccountId = account.AccountId, LocaleName = localeName }).ToList(); return dtoItems.Select(d => new ImportItem { DtoItem = d, AccountId = account.AccountId, LocaleName = account.Locale?.Name }).ToList();
} }
private static async Task<int> importIntoDbAsync(List<ImportItem> importItems) private static async Task<int> importIntoDbAsync(List<ImportItem> importItems)

View File

@ -72,7 +72,7 @@ namespace FileLiberator
libraryBook.Book.Title, libraryBook.Book.Title,
libraryBook.Book.AudibleProductId, libraryBook.Book.AudibleProductId,
libraryBook.Book.Locale, libraryBook.Book.Locale,
libraryBook.Account, Account = libraryBook.Account?.ToMask() ?? "[empty]",
tempAaxFilename, tempAaxFilename,
actualFilePath, actualFilePath,
length, length,

View File

@ -93,5 +93,11 @@ namespace InternalUtilities
} }
public override string ToString() => $"{AccountId} - {Locale?.Name ?? "[empty]"}"; public override string ToString() => $"{AccountId} - {Locale?.Name ?? "[empty]"}";
public string MaskedLogEntry => @$"AccountId={mask(AccountId)}|AccountName={mask(AccountName)}|Locale={Locale?.Name ?? "[empty]"}";
private static string mask(string str)
=> str is null ? "[null]"
: str == string.Empty ? "[empty]"
: str.ToMask();
} }
} }

View File

@ -32,7 +32,7 @@ namespace InternalUtilities
{ {
Serilog.Log.Logger.Information("GetApiAsync. {@DebugInfo}", new Serilog.Log.Logger.Information("GetApiAsync. {@DebugInfo}", new
{ {
AccountId = account?.AccountId.ToMask() ?? "[empty]", Account = account?.MaskedLogEntry ?? "[null]",
LocaleName = account?.Locale?.Name LocaleName = account?.Locale?.Name
}); });
return EzApiCreator.GetApiAsync( return EzApiCreator.GetApiAsync(

View File

@ -13,7 +13,7 @@
<!-- <PublishSingleFile>true</PublishSingleFile> --> <!-- <PublishSingleFile>true</PublishSingleFile> -->
<RuntimeIdentifier>win-x64</RuntimeIdentifier> <RuntimeIdentifier>win-x64</RuntimeIdentifier>
<Version>4.1.2.1</Version> <Version>4.1.2.2</Version>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>