From 5d4bcb2db0d936a1bb7e49f6c0fd5f2131064064 Mon Sep 17 00:00:00 2001 From: Michael Bucari-Tovo Date: Fri, 2 Jul 2021 13:50:18 -0600 Subject: [PATCH] Removed unnecessary conversion to List. --- DtoImporterService/BookImporter.cs | 4 ++-- DtoImporterService/LibraryImporter.cs | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/DtoImporterService/BookImporter.cs b/DtoImporterService/BookImporter.cs index 8d6bbd27..4fe3a70e 100644 --- a/DtoImporterService/BookImporter.cs +++ b/DtoImporterService/BookImporter.cs @@ -21,7 +21,7 @@ namespace DtoImporterService new CategoryImporter(DbContext).Import(importItems); // get distinct - var productIds = importItems.Select(i => i.DtoItem.ProductId).ToList(); + var productIds = importItems.Select(i => i.DtoItem.ProductId); // load db existing => .Local loadLocal_books(productIds); @@ -31,7 +31,7 @@ namespace DtoImporterService return qtyNew; } - private void loadLocal_books(List productIds) + private void loadLocal_books(IEnumerable productIds) { var localProductIds = DbContext.Books.Local.Select(b => b.AudibleProductId); var remainingProductIds = productIds diff --git a/DtoImporterService/LibraryImporter.cs b/DtoImporterService/LibraryImporter.cs index 48e9b628..b0077145 100644 --- a/DtoImporterService/LibraryImporter.cs +++ b/DtoImporterService/LibraryImporter.cs @@ -34,8 +34,8 @@ namespace DtoImporterService // // CURRENT SOLUTION: don't re-insert - var currentLibraryProductIds = DbContext.Library.Select(l => l.Book.AudibleProductId).ToList(); - var newItems = importItems.Where(dto => !currentLibraryProductIds.Contains(dto.DtoItem.ProductId)).ToList(); + var currentLibraryProductIds = DbContext.Library.Select(l => l.Book.AudibleProductId); + var newItems = importItems.Where(dto => !currentLibraryProductIds.Contains(dto.DtoItem.ProductId)); foreach (var newItem in newItems) { @@ -55,7 +55,7 @@ namespace DtoImporterService u.UpdateAccount(item.AccountId); } - var qtyNew = newItems.Count; + var qtyNew = newItems.Count(); return qtyNew; } }