From 6aa544b322521cdddcba88ded7423e481bac5bfc Mon Sep 17 00:00:00 2001 From: Robert McRackan Date: Tue, 5 Nov 2019 21:48:02 -0500 Subject: [PATCH] Minor changes --- FileManager/UNTESTED/FileUtility.cs | 5 ----- LibationWinForm/UNTESTED/Form1.cs | 2 +- __TODO.txt | 19 +++++++------------ 3 files changed, 8 insertions(+), 18 deletions(-) diff --git a/FileManager/UNTESTED/FileUtility.cs b/FileManager/UNTESTED/FileUtility.cs index 7ad987f1..4f391bde 100644 --- a/FileManager/UNTESTED/FileUtility.cs +++ b/FileManager/UNTESTED/FileUtility.cs @@ -70,10 +70,5 @@ namespace FileManager property = property.Replace(ch.ToString(), ""); return property; } - - public static string TitleCompressed(string title) - => new string(title - .Where(c => (char.IsLetterOrDigit(c))) - .ToArray()); } } diff --git a/LibationWinForm/UNTESTED/Form1.cs b/LibationWinForm/UNTESTED/Form1.cs index a8e649ad..d361520c 100644 --- a/LibationWinForm/UNTESTED/Form1.cs +++ b/LibationWinForm/UNTESTED/Form1.cs @@ -115,7 +115,7 @@ namespace LibationWinForm // update bottom numbers var pending = noProgress + downloadedOnly; var text - = !results.Any() ? "No books. Begin by indexing your library" + = !results.Any() ? "No books. Begin by importing your library" : pending > 0 ? string.Format(backupsCountsLbl_Format, noProgress, downloadedOnly, fullyBackedUp) : $"All {"book".PluralizeWithCount(fullyBackedUp)} backed up"; statusStrip1.UIThread(() => backupsCountsLbl.Text = text); diff --git a/__TODO.txt b/__TODO.txt index a35907a8..7a7319a6 100644 --- a/__TODO.txt +++ b/__TODO.txt @@ -80,6 +80,12 @@ Why are tags in file AND database? extract FileManager dependency from data layer -- end TAGS --------------------------------------------------------------------------------------------------------------------- +-- begin ENHANCEMENT, PERFORMANCE: TAGS --------------------------------------------------------------------------------------------------------------------- +tag edits still take forever and block UI +unlikely to be an issue with file write. in fact, should probably roll back this change +also touches parts of code which: db write via a hook, search engine re-index +-- end ENHANCEMENT, PERFORMANCE: TAGS --------------------------------------------------------------------------------------------------------------------- + -- begin ENHANCEMENT, CATEGORIES --------------------------------------------------------------------------------------------------------------------- add support for multiple categories when i do this, learn about the different CategoryLadder.Root enums. probably only need Root.Genres @@ -136,20 +142,9 @@ directly call ffmpeg (decrypt only) 39 sec decrypt -- end DECRYPTING --------------------------------------------------------------------------------------------------------------------- --- begin ENHANCEMENT, UI: LONG RUNNING TASKS --------------------------------------------------------------------------------------------------------------------- -long running tasks are appropriately async. however there's no way for the user to see that the task is running (vs nothing happened) except to wait and see if the final notification ever comes -need events to update UI with progress --- end ENHANCEMENT, UI: LONG RUNNING TASKS --------------------------------------------------------------------------------------------------------------------- - --- begin ENHANCEMENT, PERFORMANCE: TAGS --------------------------------------------------------------------------------------------------------------------- -tag edits still take forever and block UI -unlikely to be an issue with file write. in fact, should probably roll back this change -also touches parts of code which: db write via a hook, search engine re-index --- end ENHANCEMENT, PERFORMANCE: TAGS --------------------------------------------------------------------------------------------------------------------- - -- begin ENHANCEMENT: REMOVE BOOK --------------------------------------------------------------------------------------------------------------------- how to remove a book? -previously difficult due to implementation details regarding scraping and importing. should be trivial after api replaces scraping +previously difficult due to implementation details regarding scraping and importing. should now be trivial -- end ENHANCEMENT: REMOVE BOOK --------------------------------------------------------------------------------------------------------------------- -- begin ENHANCEMENT: NEW VIEWS ---------------------------------------------------------------------------------------------------------------------