Merge branch 'rmcrackan:master' into master

This commit is contained in:
Mbucari 2022-06-17 16:46:31 -06:00 committed by GitHub
commit c4c9786050
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions

View File

@ -3,7 +3,7 @@
<PropertyGroup> <PropertyGroup>
<TargetFramework>net6.0-windows</TargetFramework> <TargetFramework>net6.0-windows</TargetFramework>
<Version>8.0.1.1</Version> <Version>8.0.2.1</Version>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>

View File

@ -25,6 +25,9 @@ namespace LibationWinForms
//// Only use while debugging. Acts erratically in the wild //// Only use while debugging. Acts erratically in the wild
//AllocConsole(); //AllocConsole();
// run as early as possible. see notes in postLoggingGlobalExceptionHandling
Application.SetUnhandledExceptionMode(UnhandledExceptionMode.CatchException);
ApplicationConfiguration.Initialize(); ApplicationConfiguration.Initialize();
//***********************************************// //***********************************************//
@ -193,8 +196,9 @@ namespace LibationWinForms
// these 2 lines makes it graceful. sync (eg in main form's ctor) and thread exceptions will still crash us, but event (sync, void async, Task async) will not // these 2 lines makes it graceful. sync (eg in main form's ctor) and thread exceptions will still crash us, but event (sync, void async, Task async) will not
Application.ThreadException += (_, e) => MessageBoxLib.ShowAdminAlert(null, "Libation has encountered an unexpected error.", "Unexpected error", e.Exception); Application.ThreadException += (_, e) => MessageBoxLib.ShowAdminAlert(null, "Libation has encountered an unexpected error.", "Unexpected error", e.Exception);
// I never found a case where including made a difference. I think this enum is default and including it will override app user config file // move to beginning of execution. crashes app if this is called post-RunInstaller: System.InvalidOperationException: 'Thread exception mode cannot be changed once any Controls are created on the thread.'
Application.SetUnhandledExceptionMode(UnhandledExceptionMode.CatchException); //// I never found a case where including made a difference. I think this enum is default and including it will override app user config file
//Application.SetUnhandledExceptionMode(UnhandledExceptionMode.CatchException);
} }
} }
} }