tyler/Libation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Workaround for DataGridView filtering internal NullReferenceException

Browse Source
This commit is contained in:
Michael Bucari-Tovo 2025-02-10 10:20:18 -07:00
parent 8ec7e5a9d2
commit e911344850
1 changed files with 27 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
Source/LibationWinForms/GridView/ProductsDisplay.cs
View File

@ -89,11 +89,34 @@ namespace LibationWinForms.GridView
displayWindow.Show(this); displayWindow.Show(this);
} }
private void productsGrid_DetailsClicked(ILibraryBookEntry liveGridEntry) private async void productsGrid_DetailsClicked(ILibraryBookEntry liveGridEntry)
{ {
var bookDetailsForm = new BookDetailsDialog(liveGridEntry.LibraryBook); // HACK: workaround for a Winforms bug.
if (bookDetailsForm.ShowDialog() == DialogResult.OK) // This event is fired by the DataGridCell.OnMouseUpInternal
liveGridEntry.LibraryBook.UpdateUserDefinedItem(bookDetailsForm.NewTags, bookDetailsForm.BookLiberatedStatus, bookDetailsForm.PdfLiberatedStatus); // method. If any user changes made in the BookDetailsDialog
// result in the entry's row being removed from the DataGridView,
// then when this event handler returns, OnMouseUpInternal will
// throw a NRE trying to access the DataGridCell.DataGridView
// property.
//Steps to cause the bug:
// * book has tag: asdf
// * filter is `[asdf]`
// * tag asdf is removed from book
// * DataGridView throws NRE
//The workaround is to make this event handler execute
//asynchronously so that DataGridCell.OnMouseUpInternal completes
//before the user can change the DataGridView state.
await Task.Run(() => this.Invoke(runAsync));
void runAsync()
{
var bookDetailsForm = new BookDetailsDialog(liveGridEntry.LibraryBook);
if (bookDetailsForm.ShowDialog() == DialogResult.OK)
liveGridEntry.LibraryBook.UpdateUserDefinedItem(bookDetailsForm.NewTags, bookDetailsForm.BookLiberatedStatus, bookDetailsForm.PdfLiberatedStatus);
}
} }
#endregion #endregion