From fdee254020e7c79d894d15541045b44545523c03 Mon Sep 17 00:00:00 2001 From: Michael Bucari-Tovo Date: Mon, 20 Jun 2022 09:04:06 -0600 Subject: [PATCH] Only copy files if conversion succeeded. --- Source/FileLiberator/ConvertToMp3.cs | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/Source/FileLiberator/ConvertToMp3.cs b/Source/FileLiberator/ConvertToMp3.cs index 40077c6c..14a75b9b 100644 --- a/Source/FileLiberator/ConvertToMp3.cs +++ b/Source/FileLiberator/ConvertToMp3.cs @@ -59,13 +59,19 @@ namespace FileLiberator m4bBook.InputStream.Close(); mp3File.Close(); + if (result == ConversionResult.Failed) + { + FileUtility.SaferDelete(mp3File.Name); + return new StatusHandler { "Conversion failed" }; + } + else if (result == ConversionResult.Cancelled) + { + FileUtility.SaferDelete(mp3File.Name); + return new StatusHandler { "Cancelled" }; + } + var realMp3Path = FileUtility.SaferMoveToValidPath(mp3File.Name, proposedMp3Path); OnFileCreated(libraryBook, realMp3Path); - - if (result == ConversionResult.Failed) - return new StatusHandler { "Conversion failed" }; - else if (result == ConversionResult.Cancelled) - return new StatusHandler { "Cancelled" }; } return new StatusHandler(); }